testing: use repo path that does not need updating when import path changes #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting way, LGTM. |
|
👍 |
rogpeppe
added a commit
that referenced
this pull request
Aug 1, 2014
testing: use repo path that does not need updating when import path changes
|
LGTM but what is the gain? isn't it just 2 ways to do the same thing? |
jrwren
pushed a commit
to jrwren/charm
that referenced
this pull request
Aug 6, 2014
Update to gopkg.in/mgo.v2 repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was easy to forget to change the package path when updating the gopkg.in version,
and govers doesn't know enough to be able to warn about it, unlike import paths.