Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: use charm.v4 #58

Closed
wants to merge 1 commit into from
Closed

all: use charm.v4 #58

wants to merge 1 commit into from

Conversation

rogpeppe
Copy link
Contributor

@rogpeppe rogpeppe commented Aug 6, 2014

This is an almost entirely mechanical change, made by running "govers gopkg.in/juju/charm.v4".

@rogpeppe
Copy link
Contributor Author

rogpeppe commented Aug 6, 2014

Note that dependencies.tsv is not yet updated because charm.v4 has not yet landed.

@jujugui
Copy link
Contributor

jujugui commented Aug 6, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/charmstore/69/

@jrwren
Copy link
Contributor

jrwren commented Aug 6, 2014

LGTM

@frankban
Copy link
Member

frankban commented Aug 6, 2014

👍 We just need to also update the dependencies file for this to be landed.

@frankban
Copy link
Member

frankban commented Aug 6, 2014

Closing because we no longer need this.

@frankban frankban closed this Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rogpeppe @jujugui @jrwren @frankban