Implement the bundles-containing API endpoint. #78
Conversation
|
Test PASSed. |
| @@ -228,6 +228,9 @@ func bundleCharms(data *charm.BundleData) ([]*charm.Reference, error) { | |||
| return nil, errgo.Mask(err) | |||
| } | |||
| urlMap[url.String()] = url | |||
| // Also add the corresponding base URL. | |||
| base := baseURL(url) | |||
| urlMap[base.String()] = base | |||
There was a problem hiding this comment.
Or just:
urlMap[base.String() = baseURL(url)
?
There was a problem hiding this comment.
I don't follow this, we need to define base to be able to do base.String().
There was a problem hiding this comment.
Good point. Ignore me :-)
|
LGTM, with some small remarks (validation and "flat" names). |
|
Very nice stuff, thanks. LGTM modulo the above comments and suggestions. |
|
Test PASSed. |
|
Thanks for the reviews! |
… if flags are invalid.
…taining API endpoint.
|
Test PASSed. |
|
Test PASSed. |
|
👍 |
|
Test PASSed. |
| case "1": | ||
| return true, nil | ||
| } | ||
| return false, errgo.Newf(`value must be either "0", "1" or empty, but %q passed`, value) |
There was a problem hiding this comment.
errgo.Newf(`unexpected bool value %q (must be "0" or "1")`, value)
?
(probably not worth mentioning that it can be empty - that's just to allow
it to be omitted)
|
A few more suggestions, but still LGTM. |
|
Test PASSed. |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmstore-merge |
Implement the bundles-containing API endpoint.
No description provided.