Implement the archive delete API endpoint. #80
Conversation
Also fixed tests not properly skipped in the case Mongo has no JS support, and improved the test separation when counters are exercised.
|
Test PASSed. |
|
Test PASSed. |
| if err := h.store.BlobStore.Remove(blobName); err != nil { | ||
| return errgo.Notef(err, "cannot remove blob %s", blobName) | ||
| } | ||
| // TODO frankban 2014-08-25: log possible IncCounter errors. |
There was a problem hiding this comment.
Didn't we agree TODO needed bug numbers when reviewed? Or was that just XXX?
There was a problem hiding this comment.
Uros is adding a card on the board.
Logging is a feature still under discussion.
Thanks for the good catch.
|
👍 |
1 similar comment
|
👍 |
| @@ -35,6 +35,8 @@ func (h *handler) serveArchive(id *charm.Reference, w http.ResponseWriter, req * | |||
| default: | |||
| // TODO(rog) params.ErrMethodNotAllowed | |||
| return errgo.Newf("method not allowed") | |||
| case "DELETE": | |||
There was a problem hiding this comment.
Please add the link to the doc API for delete implementation.
|
With comments, otherwise 👍 |
…ional test as per review.
|
Thanks for the reviews! |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/charmstore-merge |
|
Test PASSed. |
Implement the archive delete API endpoint. Also fixed tests not properly skipped in the case Mongo has no JS support, and improved the test separation when counters are exercised.
Also fixed tests not properly skipped in the case Mongo
has no JS support, and improved the test separation
when counters are exercised.