Fix gccgo compatibility #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a conditional constant to deal with the implementation differences between gc and gccgo.
There is one test still to fix (down from 5)
--- FAIL: TestMask (0.00 seconds)
errors_test.go:231: unexpected details: want "[{/home/dfc/src/github.com/juju/errgo/errors_test.go:39: } {/home/dfc/src/github.com/juju/errgo/errors_test.go:38: foo}]"; got "[{} {foo}]"
| @@ -334,7 +334,7 @@ func MaskFunc(allow ...func(error) bool) func(error, ...func(error) bool) error | |||
| allowEither = allow | |||
| } | |||
| err = Mask(err, allowEither...) | |||
| setLocation(err, 1) | |||
| // setLocation(err, 0) | |||
There was a problem hiding this comment.
Why was this one removed?
|
I've addressed your comments, this change is now just adjusting the caller offset for gc vs gccgo |
|
Now with the expected usage test case from pull/3 we not get that failing with this change as I expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a conditional constant to deal with the implementation differences between gc and gccgo.
There is one test still to fix (down from 5)
--- FAIL: TestMask (0.00 seconds)
errors_test.go:231: unexpected details: want "[{/home/dfc/src/github.com/juju/errgo/errors_test.go:39: } {/home/dfc/src/github.com/juju/errgo/errors_test.go:38: foo}]"; got "[{} {foo}]"