Introduce QuotaLimitExceeded error #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 similar comment
|
|
jameinel
reviewed
Mar 31, 2020
|
|
||
| // QuotaLimitExceededf returns an error which satisfies IsQuotaLimitExceeded. | ||
| func QuotaLimitExceededf(format string, args ...interface{}) error { | ||
| return "aLimitExceeded{wrap(nil, format, "", args...)} |
There was a problem hiding this comment.
So I noticed that Err itself is returned as a struct, not as a *struct. Given that quotaLimitExceeded is-a Err, shouldn't we just return quotaLimitExceeded here?
There was a problem hiding this comment.
You are right. There is really no point in returning pointers here (or using pointer receivers for Error for that matter). I just emulated (a.k.a copy/paste/modify) the behavior from the other error types in the same file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new generic error type for representing failures due to quota limit checkes.