Fixes panics found in Juju for nil errors. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlm
force-pushed
the
fix-error-wrap-panic
branch
from
d316f91
to
609dbd4
Compare
wallyworld
approved these changes
Mar 28, 2022
When supplying a nil error to an error type wrapper in Juju you risk a panic on the Locationer as it relies on the error being non nil for the Error() func to work. Fix here is just to make an empty error when the error provided is nil. This fix will allow users to not shoot their foot off.
tlm
force-pushed
the
fix-error-wrap-panic
branch
from
609dbd4
to
0a6bdef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When supplying a nil error to an error type wrapper in Juju you risk a
panic on the Locationer as it relies on the error being non nil for the
Error() func to work.
Fix here is just to make an empty error when the error provided is nil.
This fix will allow users to not shoot their foot off.