Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use v1 suffix for imports and module name #89

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Use v1 suffix for imports and module name #89

merged 1 commit into from
Mar 23, 2021

Conversation

achilleasa
Copy link
Contributor

This PR tidies up the loose ends left by #88.

pengale
pengale approved these changes Mar 22, 2021
View reviewed changes
Copy link

@pengale pengale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense (and might explain some of the weirder behaviors I've seen w/ Juju talking to what might have been the wrong version of the MAAS api).

@achilleasa
Copy link
Contributor Author

$$merge$$

@jujubot jujubot merged commit c3f89ce into juju:v1 Mar 23, 2021
@achilleasa achilleasa deleted the v1-use-correct-module-version branch March 23, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengale pengale pengale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achilleasa @pengale @jujubot