Code for the juju http wrapper package. #1
Conversation
Makefile
Outdated
| # Reformat source files. | ||
| format: | ||
| ## format: Format the go source code | ||
| gofmt -w -l . |
There was a problem hiding this comment.
nit: new line at end of file.
| // a Client with a locally constructed Transport via NewHttpTLSTransport | ||
| // and init() will no longer be needed. | ||
| func init() { | ||
| defaultTransport := http.DefaultTransport.(*http.Transport) |
There was a problem hiding this comment.
Can we remove this init() function, it's considered an anti-pattern?
Also, this modifies every http.DefaultTransport and I'm pretty sure we don't want to do that...!
There was a problem hiding this comment.
Also, nobody is using defaultTransport locally.
There was a problem hiding this comment.
defaultTransport is used for an argument with the function calls after. Unfortunately we need this to get some transport changes in for juju. juju tests currently require being able to change the DefaultTransport to add different schemes for test and replace the RoundTripper. Updating the tests needs to be done, but make take weeks of effort which we do not have at this time. Small updates can be make to use httptest instead and chip away at the problem. The follow on pr in juju/juju starts that.
hmlanigan
force-pushed
the
initial
branch
2 times, most recently
from
dc40df1
to
a436e6c
Compare
|
@SimonRichardson, agreed, makes me sad as well. https://bugs.launchpad.net/juju/+bug/1888888. |
This code has been moved from juju/utils with a few differences: there is one constructure which takes a config; does not cache proxy settings; uses httptrace on http.Get methods.
|
!!build!! |
|
Looking to creating a merge job and check merge job for this repo. Then will merge. |
|
!!build!! |
1 similar comment
|
!!build!! |
|
Build finished. |
|
|
|
Build finished. |
|
|
This code has been moved from juju/utils with a few differences: there is one constructer which takes a config, including the ability to pass a logger; it does not cache proxy settings; and uses httptrace on http.Get methods when trace logging enabled.