This repository has been archived by the owner on May 12, 2021. It is now read-only.
Fire destroy-inspector event when a zip is dropped on the canvas fixes #1278559 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Check to make sure the event to destroy any previously | ||
| // open inspector is fired | ||
| assert.equal(topoFireStub.calledOnce(), true); | ||
| assert.equal(topoFireStub.lastArguments()[0], 'destroyServiceInspector'); |
There was a problem hiding this comment.
The topoFireStub code is the new test addition. The rest is just refactor to use the makeStubMethod util method.
|
Test PASSed. |
|
QA ok, thanks for the branch. 👍 |
|
Thanks for the review! |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Feb 11, 2014
__To QA__ Deploy a charm and open the service inspector. Drop a .zip onto the canvas and the old inspector should close and the series-select inspector should open.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To QA
Deploy a charm and open the service inspector.
Drop a .zip onto the canvas and the old inspector should close and the series-select inspector should open.