This repository has been archived by the owner on May 12, 2021. It is now read-only.
Create inspector subclass **WIP - Throwaway** #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
Modified the viewlet manager to no longer support viewlets.
|
Test FAILed. |
|
|
||
| viewletManager.render(); | ||
| viewletManager.showViewlet('requestSeries'); | ||
| new Y.juju.views.RequestSeriesInspector({ |
|
This is really good and I love how it's a lot of lines removed for just the one case. My only questions is that the views end up extending the ViewletManager and they have a .viewletmanager property assigned on them. It seems like we could make this split a little bit cleaner? |
|
Closing this PR now. Thanks for the review/discussion! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.