This repository has been archived by the owner on May 12, 2021. It is now read-only.
Create ghost inspector subclass #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2014 16:54
Created a service inspector utils extension for both the ghost and service inspector subclasses to use.
|
Test FAILed. |
|
QA okay, giving code a thorough look-over. |
|
👍 |
|
Thanks for the review/qa! |
|
Build failed: Attempt to land pull request failed |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Mar 13, 2014
This branch moves a lot of code around and will be cleaned up a lot more when we have the service inspector subclass as well. __To QA__ Do extensive exploratory QA on anything that involves the ghost inspector.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch moves a lot of code around and will be cleaned up a lot more when we have the service inspector subclass as well.
To QA
Do extensive exploratory QA on anything that involves the ghost inspector.