Create the service inspector inspector subclass #180
Conversation
|
Test FAILed. |
| inspector = new views.ServiceInspector( | ||
| model, combinedConfig); | ||
| inspector = new Y.juju.views.ServiceInspector(Y.mix({ | ||
| db: db, |
There was a problem hiding this comment.
not a fan of the Mix in the function call. It blurs what's the signature of the ServiceInspector and what's part of that mix call.
There was a problem hiding this comment.
Alright, we still need to be able to pass config data into this method so I can split it out to make it clearer as to what's happening.
|
QA Okay 👍 |
|
👍 no qa |
|
Test PASSed. |
|
Thanks for the reviews and qa! |
|
Changes made |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
|
Test PASSed. |
This is the final major branch in the inspector viewlet to view conversion. __To QA__ Do an extensive exploratory QA on the various inspectors and their tabs, interactions etc.
This is the final major branch in the inspector viewlet to view conversion.
To QA
Do an extensive exploratory QA on the various inspectors and their tabs, interactions etc.