Fixes #1288450 - Adds confirmation dialogue to config file upload in the service inspector

[hatched]

Notes

Create a config.yaml file with the following contents:

ceph:
  auth-supported: "foo"

To QA

Ghost Inspector

• Drag and drop ceph from the charm browser
• Click the config file upload button and select the config.yaml file.
• The config options should disappear.
• Click to remove the file
• The config options should reappear.
• Click the config file upload button and select the config.yaml file.
• Deploy the charm.
• Change to the settings tab and the auth-supported value should read foo.

Service Inspector

• Deploy ceph
• Click the settings tab and then click to upload the config.yaml file.
• The config options should disappear.
• Click to remove the file
• The config options should reappear.
• Click the config file upload button and select the config.yaml file.
• Click save changes.
• The auth-supported value should now read foo.

[jujugui]

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/588/

[kadams54]

When I upload in the ghost inspector and then deploy, the auth-supported value is still cephx. When I save the changes in the service inspector, auth-supported changes to foo, but cephx flashes briefly before it is set to the right value.

[hatched]

Good catch! Sorry I blanked that the config file upload functionality is not supported in the fakebackend (the juju simulator when running in sandbox mode). I just tested on a real ec2 env and it deploys with the appropriate configuration options.

[mitechie]

👍 thanks for following through on the fix.

[hatched]

Thanks all for the reviews!

[jujugui]

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge