Charmbrowser dispatcher #235
Conversation
… does not yet support the view navigate
|
Test PASSed. |
| @@ -388,7 +398,26 @@ YUI.add('subapp-browser', function(Y) { | |||
| @param {Object|String} metadata The metadata to pass to the charmbrowser | |||
| view. | |||
| */ | |||
| _charmbrowser: function(metadata) {}, | |||
| _charmbrowser: function(metadata) { | |||
| // If there is no provided metadata show the defaults. | |||
There was a problem hiding this comment.
I guess this comment refers to code at line 408 and should be move below?
There was a problem hiding this comment.
Yes, moving, thanks
|
👍 and QA ok. |
|
Thanks for the review! Good catches, all fixed! |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
|
Test PASSed. |
This branch now uses the new state object to render the charmbrowser urls. #### Notes This branch is blatantly missing tests for this new functionality. #### To QA Visit the following urls: - /precise/apache2/:flags:/state/?text=apache2#related-charms ( should show the search results, charm details, and related-charms pane ) - /precise/apache2/:flags:/state/#related-charms ( should show the editorial results, charm details and the related-charms pane ) - /precise/apache2/:flags:/state/ ( should show the charm details ) - /:flags:/state/?text=apache2 ( should show the search results )
|
Can you explain why there's blatantly no tests? |
| @@ -431,10 +460,17 @@ YUI.add('subapp-browser', function(Y) { | |||
| @param {function} next callable for the next route in the chain. | |||
| */ | |||
| renderEntityDetails: function(req, res, next) { | |||
| var entityId = this.state.getCurrent('charmID'); | |||
| var entityId, hash; | |||
|
@mitechie missing tests? The only things that are missing tests in this commit are things which will be refactored out like the |
|
Sorry I was replying to the pull request comment you made of " This branch
|
|
Oh, right, that was in reference to the stuff that was going to be refactored out :-) |
This branch now uses the new state object to render the charmbrowser urls.
Notes
This branch is blatantly missing tests for this new functionality.
To QA
Visit the following urls: