This repository has been archived by the owner on May 12, 2021. It is now read-only.
Execute commands hierarchically in a commit #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a means to execute commands after commands on which they depend have already been executed. There will be two follow-up branches: * Wait until each level of the hierarchy has fully executed (i.e.: RPC callbacks received) executed before moving on to the next * Remove commands from the changeset after they have executed. Fixed test that was doing a deep-equal on an object that had changed.
|
To QA: Use |
| } | ||
| } | ||
|
|
||
| function placeIfNeeded(value, key) { |
There was a problem hiding this comment.
I'd prefer if all of these nested function calls were methods on ECS with the data passed into them on each call.
|
👍 Thanks for this branch it looks good! |
|
Test PASSed. |
|
Test PASSed. |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Apr 15, 2014
This introduces a means to execute commands after commands on which they depend have already been executed. There will be two follow-up branches: * Wait until each level of the hierarchy has fully executed (i.e.: RPC callbacks received) executed before moving on to the next * Remove commands from the changeset after they have executed. Fixed test that was doing a deep-equal on an object that had changed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a means to execute commands after commands on which they depend
have already been executed. There will be two follow-up branches:
callbacks received) executed before moving on to the next
Fixed test that was doing a deep-equal on an object that had changed.