This repository has been archived by the owner on May 12, 2021. It is now read-only.
Set metadata to null on gohome event. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.fire('changeState', { sectionA: {} }); | ||
| this.fire('changeState', { | ||
| sectionA: { | ||
| metadata: null |
There was a problem hiding this comment.
it should be setting a component to null as well.
|
Test PASSed. |
|
With Rick's comment 👍 Even without that fix the QA was good. |
| search: 'apache2' } | ||
| }, sectionB: {}}; | ||
| var changeState = { | ||
| sectionA: { metadata: null } |
There was a problem hiding this comment.
Don't you need to show the component being reset here?
There was a problem hiding this comment.
Components being reset elsewhere are already tested--this is just testing that metadata can be reset safely.
|
Test FAILed. |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Apr 22, 2014
Fix the charm browser's Home button search * Set's metadata for sectionA to null on `EVT_SEARCH_GOHOME` * Adds test to test_ui_state ensuring `metadata: null` results in navigating back to '/' from a search QA with and without the `il` flag
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the charm browser's Home button search
EVT_SEARCH_GOHOMEmetadata: nullresults in navigating back to '/' from a searchQA with and without the
ilflag