Conversation
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test PASSed. |
First round of QA:
|
Test FAILed. |
Test FAILed. |
- Move view.js into charmresults.js - Move editorial.js into charmresults.js - Move the search.sj into charmresults.js - Update the code logic in browser.js to always work through charmresults.js - Make sure charmresults.js properly handles updating the results only as required by state info passed in. - Make this work with and without the `il` feature flag - Make sure home and activeID work properly in both states (`il` and not)
Test FAILed. |
I haven't yet done a review but there are a few small issues I found during QA:
|
closing, new branch is up. I will note: I have fixed the spinner for now
|
QA
Use and abuse the sidebar doing search, selecting tokens, hitting home, using direct urls to reload the page, and with and without the 馃帍/il