This repository has been archived by the owner on May 12, 2021. It is now read-only.
Apply final machine view rendering fixes from bad rebase #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
|
Test PASSed. |
|
QA ok, please add a follow up card to make sure that there are tests to make sure the headers are updated correctly on change. |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
May 9, 2014
This is the final set of changes meant to be in the machine view rendering branch that got lost in a bad rebase. This branch adds missing code comments and also sets the header labels through the widget setLabel rather than poking at the DOM. This required refactoring how we set up the headers so we can access them directly. QA: Add or remove some machines and the machine count in the header should update correctly. Selecting a machine should set the container count correctly in the container header.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final set of changes meant to be in the machine view rendering branch that got lost in a bad rebase.
This branch adds missing code comments and also sets the header labels through the widget setLabel rather than poking at the DOM. This required refactoring how we set up the headers so we can access them directly.
QA:
Add or remove some machines and the machine count in the header should update correctly.
Selecting a machine should set the container count correctly in the container header.