This repository has been archived by the owner on May 12, 2021. It is now read-only.
Add a service unit when dragging the service. #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Pull out all deplayed changes from the changeset to display to the user. | ||
| Return the URL to the service icon. |
There was a problem hiding this comment.
Let's drop an XXX in here to update to use the view helper for icon locating.
|
The QA steps above work as prescribed. |
|
QA ok 👍 |
|
Test PASSed. |
|
Thank you both for the reviews! |
|
Test PASSed. |
|
Build failed: Attempt to land pull request failed |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
|
Test PASSed. |
jujugui
added a commit
that referenced
this pull request
May 12, 2014
Also improved the changeset summary page + clean up. QA: - make devel; - visit `/:flags:/mv/il/`; - disable the simulator; - drag a service; - hit deploy in the status bar; - you should see the deployment summary: if the description hides, click cancel and then deploy again (there is a XXX comment about this issue); - click confirm, the service should be deployed with its unit; - in the JS console `app.db.units.size()` should return 1 and `app.db.units.item(0)` should show the unit with the expected properties; - the machine view should correctly show the unit (on machine 0). TODO: - do not deploy unplaced units; - env.placeUnit to place a unit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improved the changeset summary page + clean up.
QA:
/:flags:/mv/il/;hides, click cancel and then deploy again (there is a XXX comment
about this issue);
app.db.units.size()should return 1 andapp.db.units.item(0)should show the unit with the expectedproperties;
TODO: