This repository has been archived by the owner on May 12, 2021. It is now read-only.
Convert the browser tab handle controls to use their respective event systems instead of the viewmodeController #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix nasty XSS and usability bug in charm code display. To QA, look at http://localhost:8888/precise/mediawiki-10/#bws-code and choose the hooks/db-relation-changed file. You should now see the whole file. Compare this with the output on comingsoon or jujucharms.
BrowserCharmView.
Document the noble and important change from $$merge$$ to
Made a specific versions of _getSourceLink and _getRevnoLink for BrowserCharmView.
- Update the makefile to convert bzr-ism to git-ism - I have qa'd a developer release up through uploading, but killed it when I needed to auth launchpad with an oauth credential. - I have followed most of the release steps, but not all. There might still be a snag/two to work out on our first real release which we'll do next week and I'll volunteer to help with that in case I've missed a step, I just don't want to go through with a real release right now.
To QA: Sandbox: Make sure you are able to log in/out. (u: admin p: admin) Make sure the onboarding can be displayed at the root url. To clear your localstorage, open up the app and type `localStorage.clear()` in the console, then refresh, it should show the onboarding. Real Env: Make sure you are able to log in/out (password is in your environments.yaml file) http://jujugui.wordpress.com/2013/10/15/if-you-want-to-run-a-custom-gui/
- Upgrade mocha-phantomjs to get access to the --no-color feature. It's only listed in the hacking docs. - Add a in the Makefile so it's evident the option exists in the test-server.sh script. - Update test-server.sh script to check for the ENV var and set the mocha command appropriately. QA: This is done so that test results are easier to read in the jenkins CI output. The change should be present and qa'able now by looking at the test run of this pull request vs an older pull request. You have to look at the console data to see the test output. http://ci.jujugui.org:8080/job/juju-gui/88/ vs. http://ci.jujugui.org:8080/job/juju-gui/87/ NOTE: It appears that the GET requests still escape. There's nothing in phantomjs I can see to set for this and it appears this is a limitation in the implementation of the --no-color flag to mocha-phantomjs. Perhaps a patch upstream would be worthwhile at some point, but this at least helps reading/finding the actual test lines.
… double dispatch mitigation code
To QA: On sandbox visit the following urls and they should redirect to their sidebar equivalents: <url>/fullscreen <url>/fullscreen/precise/ceph-18/ <url>/sidebar/search/?text=wordpress <url>/fullscreen/search/precise/ceph-18/?text=wordpress
…o match with the new app view flow
|
Test FAILed. |
… systems instead of the viewmodeController
|
Superceded by #33 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To QA:
Use the browser toggle handles in various ways to make sure that all interactions still work.