This repository has been archived by the owner on May 12, 2021. It is now read-only.
Don't re-render summary panel when clearing deployer notifications #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 12, 2014 12:03
All we need is to clear the notification, so stick to that.
| @@ -148,7 +148,7 @@ YUI.add('deployer-bar', function(Y) { | |||
| // the line below everything seems to work just fine. | |||
| this.descriptionTimer = window.setTimeout( | |||
| Y.bind(this._hideChangeDescription, this), | |||
| 2000); | |||
| 4000); | |||
There was a problem hiding this comment.
This is the timeout for how long we see a new change listed in the deployer bar?
|
qa ok thanks for the fix |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
|
Test PASSed. |
jujugui
added a commit
that referenced
this pull request
May 12, 2014
### QA To test: 1. Drag and drop the first charm. 2. Click the Deploy button and verify the summary is correct, but don't confirm. Cancel or close the summary. 3. Drag and drop the second charm. 4. Click the Deploy button - used to be you'd get a "no uncommitted changes" message. Now you'll now see the expected list of two services and two units.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA
To test: