Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

You can now drag and drop an unplaced unit on the container header and it'll create a ghost container #316

Closed
wants to merge 3 commits into from
Closed

You can now drag and drop an unplaced unit on the container header and it'll create a ghost container #316

wants to merge 3 commits into from

Conversation

hatched
Copy link
Contributor

@hatched hatched commented May 12, 2014

To QA

  • Drag and drop the mediawiki:single bundle
  • Once it's deployed drag and drop postgres
  • Switch to the machine view
  • Click on the first machine so that it shows the containers
  • Drag the unplaced unit onto the container columns header
  • You should now have two containers, one an lxc with postgres and the other from the bundle.
  • Click commit to make sure it all commits properly.

mitechie
mitechie reviewed May 12, 2014
View reviewed changes
app/utils/environment-change-set.js
@@ -591,7 +591,10 @@ YUI.add('environment-change-set', function(Y) {
}
}, this);
// Place the unit in the db.
unit.machine = machineId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment about how this is needed for UX updates due to the model list being lazy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mitechie
Copy link
Contributor

Code looks good, will be doing QA in lxc.

@kadams54
Copy link
Contributor

QA looks good to me.

@kadams54
Copy link
Contributor

Review also looks good.

@jujugui
Copy link
Contributor

jujugui commented May 12, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/995/

@jujugui
Copy link
Contributor

jujugui commented May 12, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/997/

@jujugui
Copy link
Contributor

jujugui commented May 12, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/998/

@jujugui
Copy link
Contributor

jujugui commented May 13, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1000/

@hatched
Copy link
Contributor Author

hatched commented May 14, 2014

This was just a prototype for the demo - closing

@hatched hatched closed this May 14, 2014
@hatched hatched deleted the unit-drop-n-place branch May 15, 2014 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hatched @mitechie @kadams54 @jujugui