This repository has been archived by the owner on May 12, 2021. It is now read-only.
Ensure charmbrowser is fully removed on destroy. #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| window.flags.il = true; | ||
| charmBrowser.render(); | ||
| charmBrowser.destroy(); | ||
| assert.equal(charmBrowser.get('container').getDOMNode(), null); |
|
Test PASSed. |
|
Code looks good and QA is ok following the instructions. |
|
Thanks for the review, QA, and feedback! I'll plan on tackling the reloading next. |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
May 30, 2014
### QA
With the `il` flag.
1. Drag a service to the canvas
2. Click on the service and open the inspector
3. Close the inspector
4. Inspect the HTML of the sidebar
You should only see one set of charmbrowser HTML. You should **not** see anything like this:
<div id="yui_3_11_0_1_1401404489618_1020" ...
<div class="search-widget"...
<div class="charm-list"...
<div id="yui_3_11_0_1_1401404489618_1020" ...
<div class="search-widget"...
<div class="charm-list"...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA
With the
ilflag.You should only see one set of charmbrowser HTML. You should not see anything like this: