This repository has been archived by the owner on May 12, 2021. It is now read-only.
Cache charmbrowser requests #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty charmbrowser container on destroy Test added.
| var cachedResults = this.get('cachedResults')[apiEndpoint]; | ||
| if (cachedResults) { | ||
| callbacks.success(cachedResults); | ||
| return; |
There was a problem hiding this comment.
Thanks for clarifying that you don't need to cancel in flight requests here - Can you add a comment to why this return is required for future us :)
|
👍 with some requests for comments. QA'ing now |
|
Couple issues with QA:
|
|
Test PASSed. |
|
Deferring QA issues to a separate branch. |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
|
Test PASSed. |
jujugui
added a commit
that referenced
this pull request
Jun 2, 2014
This is a first iteration of caching charmbrowser requests. To QA, with il flag: * deploy a service * closer the inspector; interesting should load immediately * search for apache * deploy a service * close the inspector; apache search results should load imeediately.
|
Test FAILed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first iteration of caching charmbrowser requests.
To QA, with il flag: