This repository has been archived by the owner on May 12, 2021. It is now read-only.
Fix inspector breakage post-service double click. #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
👍 QA ok thank you! |
|
Thanks for looking things over. |
|
Build failed: Attempt to land pull request failed |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Jun 3, 2014
Full confession: I didn't actually do anything to fix the inspector breakage. I was able to duplicate the bug a few times initially and then unable to duplicate once I started working on it. The destructor in `viewlet-manager.js` should handle removing the DOM node, which is what I thought the original problem was. Instead I ended up removing the double click event, since there's no longer any difference between clicking once and clicking twice. ## QA With the `il` flag. 1. Drag a charm to the canvas 2. Deploy it 3. Double click on the service icon 4. Close the inspector Ensure the sidebar does not break and reverts back to the charmbrowser as expected. You can also inspect the DOM and make sure `<div class="bws-content">` has only one child.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full confession: I didn't actually do anything to fix the inspector breakage. I was able to duplicate the bug a few times initially and then unable to duplicate once I started working on it. The destructor in
viewlet-manager.jsshould handle removing the DOM node, which is what I thought the original problem was.Instead I ended up removing the double click event, since there's no longer any difference between clicking once and clicking twice.
QA
With the
ilflag.Ensure the sidebar does not break and reverts back to the charmbrowser as expected. You can also inspect the DOM and make sure
<div class="bws-content">has only one child.