Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Remove caching ability #364

Merged
merged 4 commits into from Jun 4, 2014
Merged

Remove caching ability #364

merged 4 commits into from Jun 4, 2014

Conversation

makyo
Copy link
Contributor

@makyo makyo commented Jun 4, 2014

This hides caching ability until the UI lockup involved in rendering the charm token widgets is cleared up. QA to ensure that search, interesting, and inspectors transition as expected.

// locking up when rendering the charm token widgets; the cache makes
// this very evident. Uncomment when a path forward is found for the
// widget rendering - Makyo 2014-06-04
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put a reference to the skipped test here?

@hatched
Copy link
Contributor

hatched commented Jun 4, 2014

👍 QA OK
Thanks for the quick fix!

@makyo
Copy link
Contributor Author

makyo commented Jun 4, 2014

:shipit:

@jujugui
Copy link
Contributor

jujugui commented Jun 4, 2014

Build failed: Attempt to land pull request failed
build url: http://ci.jujugui.org:8080/job/juju-gui-merge/375

@jujugui
Copy link
Contributor

jujugui commented Jun 4, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1162/

@jujugui
Copy link
Contributor

jujugui commented Jun 4, 2014

Build failed: Attempt to land pull request failed
build url: http://ci.jujugui.org:8080/job/juju-gui-merge/377

@jujugui
Copy link
Contributor

jujugui commented Jun 4, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1163/

@jujugui
Copy link
Contributor

jujugui commented Jun 4, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1165/

@makyo makyo changed the title Temporarily remove caching ability Remove caching ability Jun 4, 2014
@jujugui
Copy link
Contributor

jujugui commented Jun 4, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1167/

@jujugui
Copy link
Contributor

jujugui commented Jun 4, 2014

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Jun 4, 2014
This hides caching ability until the UI lockup involved in rendering the charm token widgets is cleared up.  QA to ensure that search, interesting, and inspectors transition as expected.
@jujugui jujugui merged commit 32db31b into juju:develop Jun 4, 2014
@makyo makyo deleted the hide-cache branch July 24, 2014 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants