This repository has been archived by the owner on May 12, 2021. It is now read-only.
Move "Destroy Service" link and icon into the inspector footer. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 QA okay! |
|
Thanks! |
|
Test PASSed. |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Jun 4, 2014
This ticket moves the link into the footer for the service inspector. This change is consistent with the ghost inspector, which already has the same link in the footer. ### QA 1. Drag a charm to the canvas and deploy it. 2. Drag a second charm to the canvas, but don't deploy it. 3. Click on the deployed service and verify that the "Destroy Service" link is anchored to the bottom of the inspector (expand some of the unit info so that you activate scrolling). 4. Click on the ghost service and verify that the location and appearance of this link is consistent between the two different types of inspectors. 5. Verify that the link and icon work as expected in both types of inspectors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket moves the link into the footer for the service inspector. This change is consistent with the ghost inspector, which already has the same link in the footer.
QA