This repository has been archived by the owner on May 12, 2021. It is now read-only.
Display constraints when creating a machine #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
|
Manually kicked off build http://ci.jujugui.org:8080/job/juju-gui/1174/ and it passed. |
|
👍 and QA OK. Thanks for getting this implemented! |
| <input type="text" name="disk"> | ||
| <label>Disk (TB)</label> | ||
| </form> | ||
| {{>constraints-form}} | ||
| <div class="actions"> | ||
| <span class="cancel secondary-action">Cancel</span> | | ||
| <span class="move primary-action">Move</span> |
There was a problem hiding this comment.
This should probably Create & Move and also use the 'create' class to add consistency across the views.
|
Thanks for this branch Huw I like the direction it's going. I am hoping that you are planning on reusing this new view for the three places that it could be used. Outside of that I have a few comments which I think simplify the flow of these interactions and would like to see these changes before it gets landed. |
|
Closing to wrap up and land in a new PR. |
Merged
jujugui
added a commit
that referenced
this pull request
Jun 11, 2014
Create machine This adds the ability to select the constraints before creating a new machine. A continuation of #366 QA: - open the machine view - click "Add machine" - a constraints form should appear - if you wish fill in some constraints - click create - a new machine token "new0" should appear To test cancel with unplaced units: - drag a service to the canvas - open the machine view - drag the unplaced unit to "Create new machine" - the unplaced unit token should have been removed and a constraints form should appear - click cancel - the unplaced unit token should reappear
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to select the constraints before creating a new machine.
QA:
To test cancel with unplaced units: