Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Import the getCloudProviderDetails util #3665

Merged
merged 7 commits into from
May 23, 2018
Merged

Import the getCloudProviderDetails util #3665

merged 7 commits into from
May 23, 2018

Conversation

huwshimi
Copy link
Member

No description provided.

@huwshimi huwshimi added this to the sardonic seven of nine milestone May 23, 2018
@jujugui
Copy link
Contributor

jujugui commented May 23, 2018

Refer to this link for build results (access rights to CI server needed):
http://ci-gce.jujugui.org:8080//job/juju-gui/8684/

@huwshimi
Copy link
Member Author

QA:

  • open your profile and click on Credentials
  • click add credentials button
  • the form should open and show the fields

@huwshimi
Copy link
Member Author

Import the getCloudProviderDetails util

frankban
frankban approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@frankban frankban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and QA is OK.
We need a follow-up branch to fix all the docs links in the add-credential sections, for all 3 clouds, as they are all wrong now.

@frankban
Copy link
Member

:shipit:

@jujugui
Copy link
Contributor

jujugui commented May 23, 2018

Status: merge request accepted. Url: http://ci-gce.jujugui.org:8080/job/juju-gui-merge

@jujugui jujugui merged commit 079e972 into juju:develop May 23, 2018
@huwshimi huwshimi mentioned this pull request May 23, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frankban frankban frankban approved these changes

Assignees
No one assigned
Labels
QA: Needed Review: Needed
Milestone
sardonic seven of nine
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huwshimi @jujugui @frankban