Update to support multiple browsers in CI tests #38
Conversation
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test FAILed. |
Test PASSed. |
Test PASSed. |
- Add support for running IE and Firefox - Update to use build-prod for testing against - Update the prod config.js to use the sandbox by default. It's not used in the charm deploys and is safe for us to change the default behaviour of without issue. - Update the process doc since we've tweaked the prod config.js settings. - Make the test running verbose in sauce tests to aid in tracking and debugging. - Update browsers we run against to be the latest firefox and current sauce supported windows.
Test PASSed. |
JUJU_GUI_TEST_BROWSER="chrome" make test-browser | ||
echo "Starting tests against IE" | ||
JUJU_GUI_TEST_BROWSER="ie" make test-browser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to run IE first because it was the most likely to fail. Any reason it's last now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our conversation in irc. I'd prefer to use Firefox (which works best) first as a smoke test. If IE fails, I'd prefer to know it was in fact IE vs
- there's a new issue that caused the test server to not come up correctly
- there's a network issue
- the test is bad in general and needs fixing in all browsers
If IE is first, I start chasing there first and it's the most expensive one to debug and trace an issue with.
LGTM, and the green CI must mean that it's working :) |
Thanks for the review! |
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
- Add to ci-check sequential browser runs of Firefox and IE. - Update the version of Firefox to 25, the latest supported by saucelabs - Update the Windows running IE due to the compatibility info on Saucelabs: - Update to use build-prod for testing against - Update the prod config.js to use the sandbox by default. It's not used in the charm deploys and is safe for us to change the default behaviour of without issue. - Update the process doc since we've tweaked the prod config.js settings. - Make the test running verbose in sauce tests to aid in tracking and debugging. https://saucelabs.com/platforms
the charm deploys and is safe for us to change the default behaviour of
without issue.
debugging.
https://saucelabs.com/platforms