This repository has been archived by the owner on May 12, 2021. It is now read-only.
Clean the delegated closing method up so it doesn't break the details on subsequent clicks. #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
Test FAILed. |
jcsackett
changed the title
| @@ -95,6 +104,7 @@ YUI.add('charm-details-view', function(Y) { | |||
| if (breakout) { breakout.removeClass('with-charm'); } | |||
| // If the view is never rendered then charmView will not exist. | |||
| if (this.charmView) { this.charmView.destroy(); } | |||
| // Target the charm details div for the inspector popout content. | |||
There was a problem hiding this comment.
Does this comment still apply?
|
👍 QA OK Thanks for this fix! |
… on subsequent clicks.
|
|
|
Test PASSed. |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Jun 12, 2014
Clean the delegated closing method up so it doesn't break the details on subsequent clicks.
|
Test PASSed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.