Select the first machine and bare metal container by default. #424
Conversation
|
Test PASSed. |
| */ | ||
| _selectFirstMachine: function() { | ||
| var machineTokens = this.get('machineTokens'); | ||
| var firstId = Object.keys(machineTokens)[0]; |
There was a problem hiding this comment.
While unlikely, the order of records in an object is not guaranteed. Is there a more resilient way of fetching this information? Like from the machine model list ex) modelList.item(0)
There was a problem hiding this comment.
The tokens are appended in the order of the object keys not the order of items in the modelList, hence using the same to pick the top item. I'm not sure if there's a more robust way of doing this. It seems to reproduce reliably.
|
👍 With the above comment addressed. Thanks! |
|
Test PASSed. |
|
Thansk @hatched this now picks the item from the dom so that it always gets the first item. |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
Select the first machine and bare metal container by default. This branch selects the first machine by default when the machine view panel is opened. Additionally, when you select a machine the bare metal container is now selected by default. QA: - drag two charms to the canvas - click deploy and confirm - open the machine view panel - the first machine should be selected and the bare metal container should be selected - click on the unselected machine - the containers for the second machine should be shown with the bare metal container selected
This branch selects the first machine by default when the machine view panel is opened. Additionally, when you select a machine the bare metal container is now selected by default.
QA: