Unit details breakout pane is a dispatched view. #426
Conversation
|
QA: Open a unit's details; url should change to /unit/$unitnumber Close the unit breakout pane; url should remove the /unit bit Open again, then hit back button. Pane should close. |
|
Test FAILed. |
| this.showViewlet('charmDetails', charm); | ||
| } else if (activeUnit >= 0) { |
There was a problem hiding this comment.
You're checking here if activeUnit is above 0 but it's default value is undefined and it can be assigned an undefined value.
There was a problem hiding this comment.
I'm actually checking if it's greater than or equal to 0; if it's undefined this will be falsey, but if i just do the if (activeUnit) when activeUnit is 0 it'll fail.
Would you prefer I do if typeof Number?
|
QA Issue: With the unit details pane open click the charm details link, the url adds /charm changes but the unit url is still there and the unit pane is still visible. |
|
Test PASSed. |
|
Thanks for this, having these new urls is going to be really nice. As mentioned on IRC, it would be nice if you could add tests to make sure the proper state objects are being fired wrt the bug which you fixed. 👍 with those tests. |
|
Test PASSed. |
|
I have added the tests. Let's |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
Unit details breakout pane is a dispatched view. This changes the unit details breakout pane to a dispatched view, rather than simply a show/hideSlot.
This changes the unit details breakout pane to a dispatched view, rather than simply a show/hideSlot.