Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Remove the old inspector scale-up UI #439

Closed
wants to merge 4 commits into from

Conversation

hatched
Copy link
Contributor

@hatched hatched commented Jul 15, 2014

This removes the old scale-up UI from the inspector and fixes a bug where the new scale-up UI would be shown on subordinates.

Note: This branch requires #437 to land first

@hatched
Copy link
Contributor Author

hatched commented Jul 15, 2014

To QA

Use the mv flag
Deploy a charm, do you see the old scale-up UI? No? Good!
Deploy a regular charm and a subordinate, open the subordinates inspector after deploying. Do you see the new scale-up UI? No? Good!

Note: There is a bug with the subordinates being deployed https://bugs.launchpad.net/juju-gui/+bug/1342414

@jujugui
Copy link
Contributor

jujugui commented Jul 15, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1426/

@jujugui
Copy link
Contributor

jujugui commented Jul 16, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1427/

@jujugui
Copy link
Contributor

jujugui commented Jul 16, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1429/

@mitechie
Copy link
Contributor

Code looks good, I'm assuming all those removed tests exist in the new scale up code? Can you verify that tests around having the right now of units show up are around somewhere?

Starting qa.

@jujugui
Copy link
Contributor

jujugui commented Jul 16, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1431/

@hatched
Copy link
Contributor Author

hatched commented Jul 16, 2014

In QA it was brought up that we can't remove this code yet because the non mv flagged code still relies on it for the scale-up functionality. I'm going to close this PR but leave the branch around for reference so that it can be re-applied in a couple weeks.

@hatched hatched closed this Jul 16, 2014
@hatched hatched deleted the remove-old-scale-up branch July 23, 2014 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants