Fixes unit listing with test update. #470
Conversation
|
To QA With mv: Add units via scale up (either manual placement or automatic). Without mv: |
|
Test FAILed. |
| @@ -540,7 +540,7 @@ YUI.add('juju-models', function(Y) { | |||
| annotations: {}, | |||
| pending: true, | |||
| charm: charm.get('id'), | |||
| unit_count: 0, // No units yet. | |||
| unit_count: 1, // No units yet. | |||
There was a problem hiding this comment.
I'm not sure we want to do this here, there shouldn't be any units added to the service at this point.
There was a problem hiding this comment.
We create an uncommitted unit immediately, this just updates the unit count for display.
There was a problem hiding this comment.
Right but that's not done here, that's done in ghost-deployer-extension.js via the addUnits call so this is assuming that we make that call. By moving the aggregates update method (mentioned below) into the addUnits call it will update this appropriately every time it's needed.
|
Test PASSed. |
|
Test FAILed. |
|
Test failure appears to be spurious--everything passes (make check, make test-debug, make test-prod) run locally. |
|
One QA question - The uncommitted stuff works for an uncommitted service, but once the service is deployed, adding units leads to "X undefined units" in the unit list in the inspector. Is this a future branch? If so, 👍 |
|
@makyo Looking into it now; I think that may be a simple oversight, if not let's do it as a follow up. |
|
👍 QA is OK. |
|
Test PASSed. |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
|
Test FAILed. |
Fixes unit listing with test update. * Call aggregate update when we add uncommitted units. The unit list and unit count update is dependent on this operation firing off. * Update tests to ensure this is called.
count update is dependent on this operation firing off.