Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Auto place #476

Merged
merged 2 commits into from Aug 5, 2014
Merged

Auto place #476

merged 2 commits into from Aug 5, 2014

Conversation

huwshimi
Copy link
Member

@huwshimi huwshimi commented Aug 4, 2014

Added a button to auto place all unplaced units onto new machines.

@huwshimi
Copy link
Member Author

huwshimi commented Aug 4, 2014

QA:

this.get('container')
.one('.column.unplaced .all-placed')
.toggleView(show);
if (show) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be shortened to state = (show) ? 'placed' : 'units';

@kadams54
Copy link
Contributor

kadams54 commented Aug 4, 2014

👍 QA is OK, with the one tweak @hatched mentioned above.

@jujugui
Copy link
Contributor

jujugui commented Aug 4, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1540/

@jujugui
Copy link
Contributor

jujugui commented Aug 5, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1546/

@huwshimi
Copy link
Member Author

huwshimi commented Aug 5, 2014

Thanks @hatched and @kadams54 :shipit:

@jujugui
Copy link
Contributor

jujugui commented Aug 5, 2014

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Aug 5, 2014
Auto place

Added a button to auto place all unplaced units onto new machines.
@jujugui jujugui merged commit fc292e0 into juju:develop Aug 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants