Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Clearing the ECS now also clears the services config #542

Merged
merged 2 commits into from Sep 11, 2014

Conversation

hatched
Copy link
Contributor

@hatched hatched commented Sep 10, 2014

No description provided.

@hatched
Copy link
Contributor Author

hatched commented Sep 10, 2014

To QA

  • Drag and deploy a service
  • Switch to it's configuration tab and change some of the values and save
  • Open the deployer bar and clear the clear changes button.
  • The inspector should close, uppon re-opening you should see the values reset to their original values.

Note: This cannot be done with a ghost service yet because of https://bugs.launchpad.net/juju-gui/+bug/1367921

@makyo
Copy link
Contributor

makyo commented Sep 10, 2014

👍 QA Okay following instructions. Nothing else appears affected in non-mv

@jujugui
Copy link
Contributor

jujugui commented Sep 10, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1808/

@huwshimi
Copy link
Member

Code and QA OK 👍

@hatched
Copy link
Contributor Author

hatched commented Sep 10, 2014

Thanks for the reviews and qa! :shipit:

@jujugui
Copy link
Contributor

jujugui commented Sep 10, 2014

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Sep 11, 2014
Clearing the ECS now also clears the services config
@jujugui jujugui merged commit 7894050 into juju:develop Sep 11, 2014
@hatched hatched deleted the clear-config-changed branch September 30, 2014 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants