Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Remove asterisks on setconfig in mv #547

Merged
merged 2 commits into from Sep 16, 2014
Merged

Conversation

makyo
Copy link
Contributor

@makyo makyo commented Sep 12, 2014

No description provided.

@jujugui
Copy link
Contributor

jujugui commented Sep 12, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1828/

Hide asterisks through CSS
@jujugui
Copy link
Contributor

jujugui commented Sep 12, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1830/

@jujugui
Copy link
Contributor

jujugui commented Sep 12, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1832/

@makyo makyo changed the title WIP: Remove asterisks on setconfig in mv Remove asterisks on setconfig in mv Sep 15, 2014
@makyo
Copy link
Contributor Author

makyo commented Sep 15, 2014

QA:

In machine view, deploy and commit a service. Change a config value in the inspector - you should see an asterisk. Save the changes - the asterisk should go away, and the uncommitted indicator will be there instead. No changes in non machine view.

@mitechie
Copy link
Contributor

Code is 👍 thanks for that css target cleanup.

@jcsackett
Copy link
Contributor

Code is 👍, QAing now.

@jcsackett
Copy link
Contributor

QA notes:

Altering a config value in the inspector worked--the asterisk was shown.
On save, the uncommitted circle appeared and the asterisk went away.
On commit, all indicators were cleared, as expected, and the value was saved properly (e.g. still there when the inspector was closed and reopened.

Everything worked as expected without the MV flag.

QA OK.

@makyo
Copy link
Contributor Author

makyo commented Sep 16, 2014

Thanks! :shipit:

@jujugui
Copy link
Contributor

jujugui commented Sep 16, 2014

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Sep 16, 2014
Remove asterisks on setconfig in mv
@jujugui jujugui merged commit 54236f2 into juju:develop Sep 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants