This repository has been archived by the owner on May 12, 2021. It is now read-only.
Prevent DOM updates after unbinding. #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QAWith the
|
|
Test FAILed. |
|
Test PASSed. |
|
👍 Thanks. Looks like some proper cleanup added. Did not QA. |
|
QA OK 👍 As requested by @mitechie I'm going to |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Sep 16, 2014
Prevent DOM updates after unbinding. Corrects bug https://launchpad.net/bugs/1368560. DOM updates were happening on a timeout for debouncing purposes, but that meant that they might happen after the DOM elements being updated (i.e., the databound DOM elements) were removed/destroyed. This change makes sure the timeout is also canceled as part of destruction.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects bug https://launchpad.net/bugs/1368560. DOM updates were happening on a timeout for debouncing purposes, but that meant that they might happen after the DOM elements being updated (i.e., the databound DOM elements) were removed/destroyed. This change makes sure the timeout is also canceled as part of destruction.