Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Do not show subordinate services in the mv unplaced unit token list #554

Merged
merged 2 commits into from Sep 15, 2014

Conversation

hatched
Copy link
Contributor

@hatched hatched commented Sep 15, 2014

This is a temporary fix to not instantiate or render subordinate services as unplaced units in the machine view. A real fix will involve having the service charm data fetch updating the unit information and having juju send the unit subordinate status in the delta.

@jujugui
Copy link
Contributor

jujugui commented Sep 15, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1840/

@hatched hatched changed the title WIP Do not show subordinate services in the mv unplaced unit token list Do not show subordinate services in the mv unplaced unit token list Sep 15, 2014
@hatched
Copy link
Contributor Author

hatched commented Sep 15, 2014

To QA (Orange box)

  • Drag wordpress to the canvas
  • Drag the precise version of ntp to the canvas
  • Deploy them
  • Switch to the cli and create a relation between these two
  • Wait for wordpress to come up
  • Switch to mv. No unplaced units should be shown

@jcsackett
Copy link
Contributor

@hatched LGTM, thanks. 👍

@jujugui
Copy link
Contributor

jujugui commented Sep 15, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/1844/

@hatched
Copy link
Contributor Author

hatched commented Sep 15, 2014

:shipit:

@jujugui
Copy link
Contributor

jujugui commented Sep 15, 2014

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Sep 15, 2014
Do not show subordinate services in the mv unplaced unit token list

This is a temporary fix to not instantiate or render subordinate services as unplaced units in the machine view. A real fix will involve having the service charm data fetch updating the unit information and having juju send the unit subordinate status in the delta.
@jujugui jujugui merged commit 973ab15 into juju:develop Sep 15, 2014
@hatched hatched deleted the sub-unplaced-1369576 branch September 30, 2014 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants