This repository has been archived by the owner on May 12, 2021. It is now read-only.
Remove unplaced units with service #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA:
|
| var service = this.get('db').services.getById(args[0]); | ||
| // Remove any unplaced units. | ||
| service.get('units').each(function(unit) { | ||
| this._lazyRemoveUnit([[unit.id]]); |
There was a problem hiding this comment.
Instead of doing this I think that it should make a single request passing in an array of the unit ids.
|
Test FAILed. |
|
Test PASSed. |
|
👍 QA OK Tested as per the qa instructions as well as having a deployed unit and unplaced units for the service. |
|
👍 QA is OK. Thanks! Tested both locally and in EC2. |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Sep 17, 2014
Remove unplaced units with service Fixes bug #1368566: when a committed service is removed it should also remove unplaced units and their entries in the changelog.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #1368566: when a committed service is removed it should also remove unplaced units and their entries in the changelog.