Remove the mv based dispatch to service inspector vs ghost inspector #576
Conversation
jcsackett
commented
Sep 23, 2014
jcsackett
commented
- Remove the flag conditional in dispatch
- Remove the ghost service inspector code
- Remove ghost service insepctor tests
|
QA: Add a service; the service inspector should come up normally. |
| @@ -175,7 +175,7 @@ | |||
| </div> | |||
| <script src="/juju-ui/assets/javascripts/spin.min.js"></script> | |||
| <script id="app-startup"> | |||
| //var flags = {}; // Declare an empty set of feature flags. | |||
| var flags = {}; // Declare an empty set of feature flags. | |||
| startSpinner = function() { | |||
There was a problem hiding this comment.
This is a drive by fix; this shouldn't have been commented out previously.
|
👍 QA is good. Nice work! QA notes: I added a service under the |
| topo: topo, | ||
| store: topo.get('store') | ||
| }, config, true); | ||
| inspector = new Y.juju.views.ServiceInspector(inspectorConfig).render(); |
There was a problem hiding this comment.
Can you look into this a little further. I don't think that this createServiceInspector method is used any longer because we instantiate everything from the browser.js so the whole thing can go.
There was a problem hiding this comment.
It's got a call site in topology.js; there's probably work to be done there excising unused code, but I don't think it's in scope for the main work here, e.g. removing the MV flag.
|
Test PASSed. |
|
Thanks for the investigation into that 👍 |
* Ghost inspector isn't valid in machine view.
jcsackett
force-pushed
the
kill-mv-flag-1
branch
from
364444c
to
db5bfad
Compare
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
|
Build failed: Attempt to land pull request failed |
|
Test PASSed. |
|
|
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
|
Build failed: Attempt to land pull request failed |
|
npm celebrates being all big but we can't get CI through |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
Remove the mv based dispatch to service inspector vs ghost inspector * Remove the flag conditional in dispatch * Remove the ghost service inspector code * Remove ghost service insepctor tests
