Notify the user that a commit has finished. #578
Conversation
|
QA: deploying changes will produce a notification once the changes have been committed to juju - this will take place after acks on a real env. |
| notifyCommitFinished: function() { | ||
| var db = this.get('db'); | ||
| db.notifications.add(new Y.juju.models.Notification({ | ||
| title: 'All changes committed', |
There was a problem hiding this comment.
can we id this with the changeset number? Changes completed commit: #3
|
👍 with the requested changes. This will add a nice little touch to the UI |
|
Test PASSed. |
|
Test FAILed. |
|
Test FAILed. |
|
👍 Thanks for the updated message with the index. |
|
I'm nervous about the tests not using the normal done() method with the Y.later stuff in there. It seems a bit like since that change we've had two failed test runs. I think what @hatched was thinking is that the 'done()' is all that's required and there's no need to have the 'called' tracking at all. This is a bit of the reverse and seems a bit unsafe. |
|
@mitechie ah, gotcha, just went in the wrong direction. Will fix. |
|
Test FAILed. |
|
Test PASSed. |
|
Thanks, |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
Notify the user that a commit has finished.
No description provided.