Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Create an added services view under /services. #606

Merged
merged 1 commit into from Oct 7, 2014
Merged

Create an added services view under /services. #606

merged 1 commit into from Oct 7, 2014

Conversation

kadams54
Copy link
Contributor

@kadams54 kadams54 commented Oct 7, 2014

The new view displays in the sidebar, along with the search widget.

@jujugui
Copy link
Contributor

jujugui commented Oct 7, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2039/

hatched
hatched reviewed Oct 7, 2014
View reviewed changes
app/subapps/browser/views/addedservices.js
views.SearchWidgetMgmtExtension
], {

events: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty object is empty

@jujugui
Copy link
Contributor

jujugui commented Oct 7, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2040/

kadams54
kadams54 reviewed Oct 7, 2014
View reviewed changes
app/subapps/browser/browser.js
@@ -237,8 +238,6 @@ YUI.add('subapp-browser', function(Y) {
*/
_charmBrowserDispatcher: function(metadata) {
this.renderCharmBrowser(metadata);
// XXX Won't be needed once window.flags.il becomes the norm. The details
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by cleanup.

@kadams54
Copy link
Contributor Author

kadams54 commented Oct 7, 2014

QA

Go to the /services URL. You should see the search widget in the sidebar, along with a message, "List added services here." Details panel should be closed.

Go to the / URL. Make sure everything looks normal with the rest of the app. Open inspectors, do searches in the charmbrowser, pop open the details panel, etc.

@hatched
Copy link
Contributor

hatched commented Oct 7, 2014

Thanks for the updates on this! 👍 QA OK

@makyo
Copy link
Contributor

makyo commented Oct 7, 2014

👍 Looks good, thanks

@kadams54
Copy link
Contributor Author

kadams54 commented Oct 7, 2014

Great, thanks for the reviews! :shipit:

@jujugui
Copy link
Contributor

jujugui commented Oct 7, 2014

Build failed: Attempt to land pull request failed
build url: http://ci.jujugui.org:8080/job/juju-gui-merge/712

@jujugui
Copy link
Contributor

jujugui commented Oct 7, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2044/

@jujugui
Copy link
Contributor

jujugui commented Oct 7, 2014

Build failed: Attempt to land pull request failed
build url: http://ci.jujugui.org:8080/job/juju-gui-merge/715

@jujugui
Copy link
Contributor

jujugui commented Oct 7, 2014

Build failed: Attempt to land pull request failed
build url: http://ci.jujugui.org:8080/job/juju-gui-merge/717

Create an added services view under /services.
fb9202d 
The new view displays in the sidebar, along with the search widget.
@kadams54
Copy link
Contributor Author

kadams54 commented Oct 7, 2014

develop branch now has Jeff's fix for what ails CI. :shipit:

@jujugui
Copy link
Contributor

jujugui commented Oct 7, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2048/

@jujugui
Copy link
Contributor

jujugui commented Oct 7, 2014

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Oct 7, 2014
@jujugui
Merge pull request #606 from kadams54/services-view
1e3629d 
Create an added services view under /services.

The new view displays in the sidebar, along with the search widget.
@jujugui jujugui merged commit 1e3629d into juju:develop Oct 7, 2014
@kadams54 kadams54 deleted the services-view branch November 24, 2014 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kadams54 @jujugui @hatched @makyo