Add support for passing a charm/bundle id as a deploy-target query parameter #624
Conversation
…rm to the commit list
…ys the charm to the sandboxed environment
|
Test FAILed. |
|
QA is OK, 👍 on the code. |
| */ | ||
| _autoplaceAndCommitAll: function() { | ||
| this.deployerBar._autoPlaceUnits(); | ||
| this.deployerBar.deploy(); |
There was a problem hiding this comment.
can we not just 'deploy' with immediate true? I guess that doesn't help with placement first, just ecs or not to ecs?
There was a problem hiding this comment.
We still won't have a placed unit but that might be a better approach even if just for the deploy command. I'll look into that.
There was a problem hiding this comment.
After looking into this, using immediate: true will help deploy the charm faster but we will still need to create a machine and place the unit on it so overall it won't gain us anything. Going to leave it as-is
|
good WIP thanks for the work |
…a default configuration setting bug
hatched
changed the title
To QAVisit the GUI with the following urls then do an exploratory QA to make sure that things like deploying bundles/charms still work as expected.
|
| @@ -569,6 +569,12 @@ YUI.add('environment-change-set', function(Y) { | |||
| @param {Object} db The database instance. | |||
| */ | |||
| prepare: function(db) { | |||
| if (!this.options || !this.options.modelId) { | |||
There was a problem hiding this comment.
This change and the following similar change are tested as a side effect of existing tests. The app falls over without these modifications.
|
Test PASSed. |
| _deployTargetDispatcher: function(entityId) { | ||
| var store = this.get('store'); | ||
| if (entityId.indexOf('bundle') === 0) { | ||
| // Query the charmstore for the bundle data |
|
👍 QA OK. I tried out the deploy-to target. I tried it with a bundle without the version and I also tried it with a charm without the cs: and it all still worked properly which was <3 |
|
Thanks for the reviews and QA! |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
Add support for passing a charm/bundle id as a deploy-target query parameter You can now add a query parameter `deploy-target` with the value a charm or bundle id to the url when loading the GUI to automatically deploy the charm or bundle to the environment.
You can now add a query parameter
deploy-targetwith the value a charm or bundle id to the url when loading the GUI to automatically deploy the charm or bundle to the environment.