Tweak how machine view renders hidden/faded/highlighted services. #625

kadams54 · 2014-10-21T22:45:39Z

The specs for how hide/highlight should work in machine view:

Show/hide

Machine view is a literal translation of hardware so we can't be so clear cut.
Hiding a service just de-prioritises the service.
The hidden service is not populated in the machine column.
The hidden services is de-prioritised in the container column. They sit at the bottom of their respective containers and stack up horizontally, the name of the service is not shown but can be found out via a tooltip which should appear from hovering over the charm icon.
The machine and containers never get hidden with show/hide.

Highlight/unhighlight

Highlighting a service changes the machine column to only show machines which include the highlighted service. This allows users to use it as a filtering tool.

kadams54 · 2014-10-21T22:48:23Z

QA

With the as flag:

Deploy a medium-to-large bundle.
Switch to the added services sidebar.
Verify that the show/highlight toggles work as described above, for machine view.

jujugui · 2014-10-21T22:50:35Z

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2111/

frankban · 2014-10-22T14:43:38Z

Some QA issues:
With make devel I deployed the mongodb:cluster bundle.
This bundle includes a central service (mongos) connected to four other
services.

Service hide:
From the service view, hiding the leafs works, but hiding mongos just hides
its relations, while the service block is still shown.
Hiding multiple services at the same time generates weird results, but perhaps
this is due to the crossover interactions not being implemented.

Service relations:
As above, everything seems to work well except for when multiple relations
are highlighted, in which case it seems only the last one is taken into
consideration. When deactivating the highlight also the behavior does not
seem to be what expected.

Machine hide:
Hiding services works very well in the machine view's top level machines
column. Hiding all the services correctly hides all the units in the columns.
The container columns is more troublesome: the units are not hidden (and this
appears to be by spec) but also the unit name is still displayed and it
seems a newline is added between the unit icon and the unit name.

Machine relations:
This seems to work very well.

frankban · 2014-10-22T14:45:16Z

app/models/models.js

+      @return {Array} A list of the service names of unrelated services.
+    */
+    findUnrelatedServices: function(db) {
+      var relationData = utils.getRelationDataForService(db, this),


Since this is a calculated value, please define it in its own var.

frankban · 2014-10-22T14:54:28Z

Code looks good with some changes.
Thanks Kyle!

jujugui · 2014-10-22T18:22:41Z

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2114/

jujugui · 2014-10-22T21:49:34Z

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2116/

hatched · 2014-10-22T22:03:21Z

app/models/models.js

@@ -303,6 +303,31 @@ YUI.add('juju-models', function(Y) {
    },

    /**
+      Returns a list of the deployed services that are not related


Doesn't this also return services which are on the canvas but not deployed?

Yes, though I consider those deployed as well, just not committed. I'll clarify.

jujugui · 2014-10-22T22:21:01Z

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2117/

jujugui · 2014-10-23T03:59:34Z

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2118/

hatched · 2014-10-23T17:29:38Z

test/test_model.js

+        {id: 'haproxy', name: 'haproxy'}
+      ]);
+      var relations = [
+        {far: {service: 'wordpress'}}


I'm curious about this method and it's support of peer relations. Have you tested/experimented with that? Maybe there should also be a peer relation here to make sure it works as intended.

I've verified that peer and subordinate relations use the same data structure, so this test should be sufficient.

jujugui · 2014-10-23T17:54:21Z

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2122/

hatched · 2014-10-23T19:21:15Z

👍 Thanks for checking on that relationship syntax

kadams54 · 2014-10-23T19:24:17Z

Woo hoo!

jujugui · 2014-10-23T19:26:31Z

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

Tweak how machine view renders hidden/faded/highlighted services. The specs for how hide/highlight should work in machine view: ## Show/hide * Machine view is a literal translation of hardware so we can't be so clear cut. * Hiding a service just de-prioritises the service. * The hidden service is not populated in the machine column. * The hidden services is de-prioritised in the container column. They sit at the bottom of their respective containers and stack up horizontally, the name of the service is not shown but can be found out via a tooltip which should appear from hovering over the charm icon. * The machine and containers never get hidden with show/hide. ## Highlight/unhighlight * Highlighting a service changes the machine column to only show machines which include the highlighted service. This allows users to use it as a filtering tool.

frankban reviewed Oct 22, 2014
View reviewed changes

kadams54 force-pushed the hide-highlight-tweaks branch from 893c6bc to 2b53993 Compare October 22, 2014 18:17

kadams54 changed the title ~~WIP: Hide/highlight tweaks~~ Tweak how machine view renders hidden/faded/highlighted services. Oct 22, 2014

kadams54 force-pushed the hide-highlight-tweaks branch 2 times, most recently from a8c4c89 to a6d2fb1 Compare October 22, 2014 21:20

hatched reviewed Oct 22, 2014
View reviewed changes

kadams54 force-pushed the hide-highlight-tweaks branch from a6d2fb1 to 73010e0 Compare October 23, 2014 03:31

Tweak how hide/highlight is rendered in MV.

93850fa

kadams54 force-pushed the hide-highlight-tweaks branch from 73010e0 to 93850fa Compare October 23, 2014 17:11

hatched reviewed Oct 23, 2014
View reviewed changes

jujugui merged commit 8a96bae into juju:develop Oct 23, 2014

kadams54 deleted the hide-highlight-tweaks branch October 24, 2014 13:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tweak how machine view renders hidden/faded/highlighted services. #625

Tweak how machine view renders hidden/faded/highlighted services. #625

kadams54 commented Oct 21, 2014

kadams54 commented Oct 21, 2014

jujugui commented Oct 21, 2014

frankban commented Oct 22, 2014

frankban Oct 22, 2014

frankban commented Oct 22, 2014

jujugui commented Oct 22, 2014

jujugui commented Oct 22, 2014

hatched Oct 22, 2014

kadams54 Oct 23, 2014

jujugui commented Oct 22, 2014

jujugui commented Oct 23, 2014

hatched Oct 23, 2014

kadams54 Oct 23, 2014

jujugui commented Oct 23, 2014

hatched commented Oct 23, 2014

kadams54 commented Oct 23, 2014

jujugui commented Oct 23, 2014

Tweak how machine view renders hidden/faded/highlighted services. #625

Tweak how machine view renders hidden/faded/highlighted services. #625

Conversation

kadams54 commented Oct 21, 2014

Show/hide

Highlight/unhighlight

kadams54 commented Oct 21, 2014

QA

jujugui commented Oct 21, 2014

frankban commented Oct 22, 2014

frankban Oct 22, 2014

Choose a reason for hiding this comment

frankban commented Oct 22, 2014

jujugui commented Oct 22, 2014

jujugui commented Oct 22, 2014

hatched Oct 22, 2014

Choose a reason for hiding this comment

kadams54 Oct 23, 2014

Choose a reason for hiding this comment

jujugui commented Oct 22, 2014

jujugui commented Oct 23, 2014

hatched Oct 23, 2014

Choose a reason for hiding this comment

kadams54 Oct 23, 2014

Choose a reason for hiding this comment

jujugui commented Oct 23, 2014

hatched commented Oct 23, 2014

kadams54 commented Oct 23, 2014

jujugui commented Oct 23, 2014