Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Permanently dismiss the "service added" message in the inspector. #626

Merged
merged 1 commit into from Oct 22, 2014

Conversation

frankban
Copy link
Member

As suggested by Luca, the message is dismissed per-model, meaning
it's not shown again for the single service inspector.

As suggested by Luca, the message is dismissed per-model, meaning
it's not shown again for the single service inspector.
@frankban
Copy link
Member Author

QA:
Devel:

  • make devel;
  • visit the GUI;
  • deploy a service (drag and drop);
  • dismiss the "Your service has been added" message in the inspector;
  • switch to the machine view: the message does not appear again;
  • switch back to service view and deploy another service;
  • the message is there;
  • click to the previously added ghost: the message is not shown;
  • click back to the second service and dismiss the message;
  • now you can switch between the two services, or between
    service and machine views, and the message is never shown;
  • auto-place the units and commit: everything should work as usual.

Real env:

  • juju quickstart an environment;
  • juju set juju-gui juju-gui-source="https://github.com/frankban/juju-gui.git dismiss-service-added";
  • wait for the GUI to be ready then visit the GUI;
  • QA as described above in Devel.

Thank you.

@jujugui
Copy link
Contributor

jujugui commented Oct 22, 2014

Test FAILed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2112/

@kadams54
Copy link
Contributor

QA is OK, code is 👍 and test failure is likely spurious.

@mitechie
Copy link
Contributor

👍 and yes the test failure is spurious. :shipit:

@mitechie
Copy link
Contributor

npm issue, try again

@jujugui
Copy link
Contributor

jujugui commented Oct 22, 2014

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Oct 22, 2014
Permanently dismiss the "service added" message in the inspector.

As suggested by Luca, the message is dismissed per-model, meaning
it's not shown again for the single service inspector.
@jujugui jujugui merged commit c69d880 into juju:develop Oct 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants