This repository has been archived by the owner on May 12, 2021. It is now read-only.
Containers with no units should still be shown. #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To QASwitch to machine view and create a machine and a container on that machine. Also play around with services deployed on containers to make sure they are rendered properly. |
|
Test PASSed. |
|
👍 QA ok, deloyed a bundle, made sure the machines/containers showed right. Then created a new machine with an lxc container in it, deployed it, and swapped back/forth from services/machine view. |
|
👍 as well. |
|
Thanks for the reviews and qa! |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
jujugui
added a commit
that referenced
this pull request
Nov 7, 2014
Containers with no units should still be shown. Fixes issue: https://bugs.launchpad.net/juju-gui/+bug/1390165 As per the latest spec the machine view is a literal representation of the hardware in the environment so if a machine has no units it should still be shown.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: https://bugs.launchpad.net/juju-gui/+bug/1390165
As per the latest spec the machine view is a literal representation of the hardware in the environment so if a machine has no units it should still be shown.