Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

On fades, only unhighlight if already highlight. #656

Merged
merged 1 commit into from Nov 14, 2014

Conversation

kadams54
Copy link
Contributor

In added services, when you fade a service, it should also toggle
highlights off. The original code would toggle the highlight flag
regardless of whether it actually needed it, which causes problems
downstream in the code.

In added services, when you fade a service, it should also toggle
highlights off. The original code would toggle the highlight flag
regardless of whether it actually needed it, which causes problems
downstream in the code.
@kadams54
Copy link
Contributor Author

QA

  1. Deploy the MongoDb Bundle.
  2. Deploy/commit/autoplace mysql.
  3. Highlight Shard 3 (works as expected).
  4. Fade Shard 2 (works as expected).
  5. Fade Mongos and verify that mysql does not become visible again.
  6. Highlight Mysql and make sure everything works as expected.
  7. Fade Mysql and verify that the highlight is toggled off.

@hatched
Copy link
Contributor

hatched commented Nov 13, 2014

👍 QA OK
I can't seem to find any more issues, we might have it this time :)

@jujugui
Copy link
Contributor

jujugui commented Nov 13, 2014

Test PASSed.
Refer to this link for build results: http://ci.jujugui.org:8080/job/juju-gui/2221/

@makyo
Copy link
Contributor

makyo commented Nov 13, 2014

👍 Thanks!

@kadams54
Copy link
Contributor Author

Another one bites the dust… :shipit:

@jujugui
Copy link
Contributor

jujugui commented Nov 14, 2014

Build failed: Attempt to land pull request failed
build url: http://ci.jujugui.org:8080/job/juju-gui-merge/783

@kadams54
Copy link
Contributor Author

NPM failure. Trying again.

@jujugui
Copy link
Contributor

jujugui commented Nov 14, 2014

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge

jujugui added a commit that referenced this pull request Nov 14, 2014
On fades, only unhighlight if already highlight.

In added services, when you fade a service, it should also toggle
highlights off. The original code would toggle the highlight flag
regardless of whether it actually needed it, which causes problems
downstream in the code.
@jujugui jujugui merged commit 323c9ed into juju:develop Nov 14, 2014
@kadams54 kadams54 deleted the fix-unhiding-unrelated-service branch November 14, 2014 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants